feat: show seconds in web display and Excel when UseOneMinuteIntervals on (Phase 4)#1543
Merged
renemadsen merged 1 commit intoMay 2, 2026
Conversation
…uteIntervals on (Phase 4) Phase 4 of the UseOneMinuteIntervals second-precision rollout. When a row's AssignedSite has the flag on: - Excel export's GetShiftTime returns HH:mm:ss strings sourced from Start1StartedAt etc. instead of the 5-min Options lookup - The web-admin plannings table displays actual-stamp cells via a new formatStamp(row, field) helper that picks 'HH:mm:ss' - The day-edit dialog's six time-pickers shift their minutesGap from 5 to 1 (minute-precision input; sub-minute input deferred per Q2(c)) - The padZero/displayTimeFormat angular helpers gain a sibling that includes :SS; the original helpers stay untouched. Behavior with the flag off is byte-identical to before. Excel export path falls through to the legacy 5-min Options[] lookup when actualStamp is null OR flag off. Plan: /home/rene/.claude/plans/parallel-twirling-balloon.md Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 4 of the UseOneMinuteIntervals second-precision rollout — web admin display + Excel export. Phases 0/1/2 are merged on stable; Phase 3 (mobile) is in flight on flutter-time PR #460.
When a row's
AssignedSite.UseOneMinuteIntervalsis on:GetShiftTimereturnsHH:mm:ssstrings sourced fromStart1StartedAtetc. instead of the legacy 5-minOptions[]lookup. Pause columns have no single representative stamp so they fall through to the 2-arg path (acceptable per plan).formatStamp(row, value)helper that picksHH:mm:ssbased on the row's per-site flag.ngx-material-timepicker[minutesGap]bindings shift from5to1(minute-precision input; sub-minute input deferred per Q2(c)).convertHoursToTimeWithSeconds/getStopTimeDisplayWithSeconds; existingpadZero/convertHoursToTime/getStopTimeDisplaystay untouched.Behavior with the flag off is byte-identical to before — every code path either delegates to the existing 2-arg method or short-circuits when
actualStampis null.Locked decisions:
F2decimal hours, out of scope for Phase 4.Test plan
dotnet clean && dotnet buildat host root — green (0 errors, 129 warnings unchanged from baseline)formatStamp,getStopTimeDisplayWithSeconds,convertHoursToTimeWithSeconds(time-plannings-table.component.spec.ts) — assertHH:mm:ssvsHH:mmbased onrow.useOneMinuteIntervals.PlanRegistrationHelperTests.csforGetShiftTimeoverload (intent captured for future fixture work, mirrors Phase 0/1/2 carve-out pattern) — covers flag-on07:03:53vs flag-off07:00.GenerateExcelDashboardshift-cell formatting (intent captured; format-helper unit test covers the contract).dashboard-edit-multishift.spec.ts— currentlytest.skipwith a TODO for fixture seeding ofAssignedSite.UseOneMinuteIntervals=true+ preciseStart1StartedAt. Format-helper jest test covers the merge-blocking contract.